Fix VotingPlugin startup delay from UUID tab completion - #306
Merged
Conversation
BenCodez
marked this pull request as ready for review
August 30, 2026 16:06
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkedHashSetArrayListAPI only after collectionRegression
AdvancedCore commit
d835afcchanged UUID tab completion from the asynchronously populated UUID/name cache to every UUID in user storage. The rebuild retainedArrayList.contains()inside the loop, making startup O(n²). With a large VotingPlugin user table, this blocks the server thread during plugin enable.This change makes the same operation O(n) without changing the completion values.
Scope
This PR only addresses the VotingPlugin/AdvancedCore UUID tab-completion startup delay. It does not alter user storage, Control, top-voter startup, or other plugin delays.