Skip to content

Bound total V2 packet read time - #168

Merged
BenCodez merged 2 commits into
masterfrom
fix/v2-packet-read-deadline-20260828
Aug 28, 2026
Merged

Bound total V2 packet read time#168
BenCodez merged 2 commits into
masterfrom
fix/v2-packet-read-deadline-20260828

Conversation

@BenCodez

@BenCodez BenCodez commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • enforce one absolute five-second deadline across V2 protocol detection and framed or unframed packet reads
  • keep V1 collision fallback reads inside the remaining V2 deadline
  • restore the socket's original timeout after parsing
  • add regression tests for framed and unframed slow-trickle inputs, including a delayed second protocol byte

Validation

  • compiled the patched production parser with Java 21
  • live socket harness: delayed-prefix unframed input timed out in 5001 ms total
  • live socket harness: framed input timed out in 5001 ms total
  • verified the original socket timeout is restored in both regression paths

Local Maven execution was attempted, but this runtime could not resolve Maven plugins because outbound Maven Central DNS is unavailable. GitHub Actions provides the full project test result.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48cbc40625

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 1368baef2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit fb65a28 into master Aug 28, 2026
1 check passed
@BenCodez
BenCodez deleted the fix/v2-packet-read-deadline-20260828 branch August 28, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant