Redesign Control dashboard shell - #12
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9177ce6030
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9177ce6 to
2b16787
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b16787e1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2b16787 to
ae246c0
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae246c09bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| issues.push(issue('informational', 'Detailed health has not been loaded', | ||
| 'Refresh the dashboard to inspect Vote Sites, VoteLog, configuration, and runtime state.', 'Refresh dashboard', 'overview')); | ||
| } | ||
| if (dashboardLoadedContext === dashboardContext()) { |
There was a problem hiding this comment.
When the initial overview request times out, fails, or returns malformed data, dashboardLoadedContext remains empty, so this condition prevents the recorded overview: 'failed' status from becoming a warning. The finally block then calls renderMetrics(), which overwrites the explicit error placed in attentionFeed; users instead see only “Detailed health has not been loaded,” an issue count of zero, and “No observed problems.” Handle the failed status even when no dashboard context was successfully loaded.
Useful? React with 👍 / 👎.
| overview: ['Refresh dashboard', () => refreshDashboard()], | ||
| servers: ['Refresh servers', () => loadNodes()], | ||
| network: ['Run Network Doctor', () => runNetworkDoctor.click()], | ||
| configurations: ['Compare configuration', () => runDriftCheck.click()], |
There was a problem hiding this comment.
When the Configurations panel is currently showing Easy View or Full YAML, the new header action starts the drift read but never calls setConfigView('compare'). Its progress and results are written to the hidden drift-results element, so the action appears to do nothing while potentially running a long multi-node operation; switch to the Compare subview before triggering the check.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Stack
This PR is intentionally based on PR #11 branch codex/control-console-foundation so its diff contains only the dashboard shell slice. Retarget to main after #11 merges.