Make Control configuration operations responsive - #1591
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c247554f16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Follow-up fix moved to #1592 because this PR was already merged and its branch was deleted. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46cabd306f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| throw new IllegalArgumentException("quick setup preset cannot be read"); |
There was a problem hiding this comment.
When Control sends a READ operation for proxy-method, executeQuick() now routes it here, but this method rejects the preset even though quickSetupFile()/quickProposal() support it and the backend advertises config.proxy-method.v1. As a result, the guided transport-method UI cannot load the backend's current method and receives VALIDATION_ERROR; handle proxy-method by returning the installed BungeeMethod, as the proxy connector already does.
Useful? React with 👍 / 👎.
| String.valueOf(yaml.getBoolean("DisableNoServiceSiteMessage", false))); | ||
| values.put("disableUpdateChecking", String.valueOf(yaml.getBoolean("DisableUpdateChecking", false))); | ||
| } else if ("vote-party".equals(preset)) { | ||
| values.put("enabled", String.valueOf(yaml.getBoolean("VoteParty.Enabled", false))); |
There was a problem hiding this comment.
When a disabled vote party is read and the returned options are submitted unchanged while editing another field, this reports enabled=false, but quickProposal() ignores that option and unconditionally writes VoteParty.Enabled: true. Thus an apparently round-trip edit silently enables vote-party processing; either honor the returned enabled option during preview/apply or omit it if this preset is intentionally enable-only.
Useful? React with 👍 / 👎.
1 participant
Summary
Control polling remains optional and isolated from vote processing.
Testing
mvn -B -f VotingPlugin/pom.xml -DargLine=-javaagent:.../byte-buddy-agent-1.17.7.jar test— 462 tests passedgit diff --checkAI assistance
Implemented and verified with OpenAI Codex.