Skip to content

Isolate Bukkit server test mock - #1593

Merged
BenCodez merged 1 commit into
masterfrom
codex/isolate-bukkit-test-server
Aug 31, 2026
Merged

Isolate Bukkit server test mock#1593
BenCodez merged 1 commit into
masterfrom
codex/isolate-bukkit-test-server

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • replace the permanent Bukkit.setServer mutation in VoteSiteAdditionalTest with a scoped Mockito static mock
  • close the mock after the class so later tests do not mistake the mock server for a registry-capable Bukkit runtime
  • preserve production Material.isItem() validation

Regression

This fixes order-dependent failures in ControlInspectionServiceTest.rewardSimulationNormalizesButNeverExecutesTypedActions and BackendConfigurationServiceTest.rewardBuilderPersistsTheTypedSiteProposalAndOnlyReplacesItsSelectedSubtree on current Spigot API snapshots.

Verification

  • focused suite: 71 tests passed
  • full suite: 496 tests passed
  • git diff --check passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T01:29:22.136776Z b0a29f9 PR opened
🔒 Security Review Completed 2026-08-31T01:29:52.285250Z b0a29f9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@BenCodez
BenCodez merged commit eb5b5ae into master Aug 31, 2026
4 checks passed
@BenCodez
BenCodez deleted the codex/isolate-bukkit-test-server branch August 31, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant