Skip to content

Feature/add street name #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mszell merged 2 commits into from
Sep 3, 2026
Merged

Feature/add street name #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b1d2dc
Add street name to gap
mszell Sep 3, 2026
cf020af
Fix gap naming
mszell Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions fixbikenet/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ def gap_declustering(gaps_df, G, ebc, contact_nodes):
]
selected_paths = []
selected_scores = []
selected_names = []

for comp in tqdm(
components,
Expand Down Expand Up @@ -741,10 +742,24 @@ def gap_declustering(gaps_df, G, ebc, contact_nodes):
best_path = path
if best_path is None:
break

# Store selected gap
selected_paths.append(best_path)
selected_scores.append(best_score)

# Walk through edges until finding a name
name = "n/a"
for i in [-1]+list(range(len(best_path))):
try:
name = G[best_path[i]][best_path[i+1]]['name']
except:
pass
if name != "" and name != "n/a":
break
if name == "":
name = "n/a"
selected_names.append(name)

# Remove selected path
edge_path = list(
zip(best_path[:-1], best_path[1:])
Expand All @@ -757,6 +772,7 @@ def gap_declustering(gaps_df, G, ebc, contact_nodes):
{
"path": selected_paths,
"benefit": selected_scores,
"name": selected_names
}
)
return result
Expand Down
Loading