Skip to content

Upgrade to @labkey/build 10.x - #406

Closed
bbimber wants to merge 3 commits into
discvr-26.3from
26.3_fb_webpack
Closed

Upgrade to @labkey/build 10.x#406
bbimber wants to merge 3 commits into
discvr-26.3from
26.3_fb_webpack

Conversation

@bbimber

@bbimber bbimber commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This PR is basically the same as bimberlabinternal/BimberLabKeyModules#231; however, the JBrowse config is a little more involved. Can you please:

  • Make sure this is working and do the same review of jbrowse npm dependencies?
  • JBrowse has custom webpack (now rspack) config files that were added to address some JBrowse-specific issues. I am not sure if these are really needed anymore. My comments in dev_config.js go into detail and have some links. For example, I dont think we need jbrowse-polyfill.
  • I also wonder if we could simplify the jbrowse dependencies. We list a lot of specific packages. We probably should be explicit if our code uses one of them; however, JBrowse does a better job of controlling their exports and we probably wont actually need to depend on all these things. Likewise, I bet JBrowse's package.json has accumulated some dependencies we dont require anymore. node-polyfill is one that's probably not needed, but I didnt test this locally.

@bbimber

bbimber commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

closed in favor of #408

@bbimber bbimber closed this Jul 24, 2026
@bbimber
bbimber deleted the 26.3_fb_webpack branch July 24, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant