fix(sdk-core): remove ECDSA guard on tssSettings fetch in generateCustodialMpcWallet#9247
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
fix(sdk-core): remove ECDSA guard on tssSettings fetch in generateCustodialMpcWallet#9247bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Contributor
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-160-remove-ecdsa-guard-custodial-mpc
branch
from
76ad613 to
b920a48
Compare
kisslove-dewangan
left a comment
kisslove-dewangan
left a comment
Contributor
There was a problem hiding this comment.
pls fix ci, rest lgtm
…todialMpcWallet Move the tssSettings fetch outside the ECDSA guard in generateCustodialMpcWallet so EdDSA custodial wallets also read custodialMultiSigTypeVersion. The determineEcdsaMpcWalletVersion call remains ECDSA-only since walletVersion 5/6 is EVM-specific. This ensures the enable-eddsa-mpcv2 Flipt flag is honoured on the client side once BGMS populates custodialMultiSigTypeVersion for EdDSA coin families (WCI-527). Ticket: WCI-160 Session-Id: a46bd88a-d2ba-4932-b622-3c84b317d929 Task-Id: 28db1331-4668-4d2c-a035-9d5eccce8861
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-160-remove-ecdsa-guard-custodial-mpc
branch
2 times, most recently
from
fae469e to
c71aab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tssSettingsfetch ingenerateCustodialMpcWalletoutside the ECDSA guard so both ECDSA and EdDSA custodial wallets readcustodialMultiSigTypeVersionfrom TSS settingsdetermineEcdsaMpcWalletVersioncall (which sets walletVersion 5/6) remains ECDSA-only since those versions are EVM-specificWhy
Previously,
generateCustodialMpcWalletgated thetssSettingsfetch behindgetMPCAlgorithm() === 'ecdsa', meaning EdDSA custodial wallets never readcustodialMultiSigTypeVersion. This made theenable-eddsa-mpcv2Flipt flag a no-op on the client side.Test plan
should create a new TSS custodial wallettest (tsol/EdDSA) to mock the now-requiredtss/settingsendpointcustodialMultiSigTypeVersion: 'MPCv2'to the EdDSA MPCv2beforeEachtssSettings fixtureshould create a new tsol TSS EdDSA MPCv2 custodial walletcovering the EdDSA custodial path whencustodialMultiSigTypeVersionis setDependencies
Requires WCI-527 — BGMS must populate
custodialMultiSigTypeVersionfor EdDSA coin families before this client-side read has any effect.Fixes WCI-160
🤖 Generated with Ralph