fix(polymarket): verify redeem effects and sweep legacy collateral#59
Open
KillerQueen-Z wants to merge 2 commits into
Open
fix(polymarket): verify redeem effects and sweep legacy collateral#59KillerQueen-Z wants to merge 2 commits into
KillerQueen-Z wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Require a confirmed ERC-1155 outcome-token decrease before redeem reports success, closing the successful no-op class.\n- Include legacy USDC.e in withdrawable collateral; wrap only the required amount to pUSD through the official collateral onramp before bridge withdrawal.\n- Add regressions for no-op detection and legacy USDC.e withdrawal previews.\n\n## Root cause\nDirect CTF redemption with pUSD-derived inputs can succeed while redeeming a zero balance. The current adapter route fixes the underlying path; this PR verifies its actual token effect and lets historical USDC.e residue leave the vault.\n\n## Validation\n- npm test (171 passing)\n- npm run typecheck\n- npm run build\n- Read-only Polygon/CLOB verification using the reported resolved BTC conditions and transactions: the zero-payout transaction had no ERC-1155 burn or USDC.e transfer; the corrected transaction burned positions and transferred 1.298700 USDC.e.\n\nNote: the current local wallet has no redeemable positions, so no user funds were moved for this test.