Repository navigation
Use the shared lwk fork and add getAddress - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lwk submodule. Switches
lwkfromlukachi/lwkto the shared forklilbonekit/lwk(feature/shared-humid-fork): only.gitmodulesand the submodule pointer. The fork keeps everything fromhumid/esplora-backend-configand fixesWollet::blind(), which dropped input issuance, nSequence and fallback locktime, so issuance transactions signed viasignPsetfailed withbad-txns-in-ne-out. Covered by a test in the fork.getAddress. New RPC method returning the account's first address (confidential and unconfidential). With SLIP-77 a dapp can't derive confidential addresses from the public descriptor, and
getUTXOsonly exposes addresses that already hold coins, so an empty account had no way to receive. It reveals only that address's public blinding key, under its own "View first address" permission. Discussed with Artem.Checked:
bun run build,bun test(759 pass); lending flows signed viasignPsetbroadcast on testnet.