Skip to content

Use the shared lwk fork and add getAddress - #55

Merged
Arvolear merged 4 commits into
masterfrom
feature/shared-lwk-fork
Oct 21, 2026
Merged

Arvolear merged 4 commits into
masterfrom
feature/shared-lwk-fork

Conversation

@lilbonekit

@lilbonekit lilbonekit commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

lwk submodule. Switches lwk from lukachi/lwk to the shared fork lilbonekit/lwk (feature/shared-humid-fork): only .gitmodules and the submodule pointer. The fork keeps everything from humid/esplora-backend-config and fixes Wollet::blind(), which dropped input issuance, nSequence and fallback locktime, so issuance transactions signed via signPset failed with bad-txns-in-ne-out. Covered by a test in the fork.

getAddress. New RPC method returning the account's first address (confidential and unconfidential). With SLIP-77 a dapp can't derive confidential addresses from the public descriptor, and getUTXOs only exposes addresses that already hold coins, so an empty account had no way to receive. It reveals only that address's public blinding key, under its own "View first address" permission. Discussed with Artem.

Checked: bun run build, bun test (759 pass); lending flows signed via signPset broadcast on testnet.

@lilbonekit lilbonekit changed the title Point lwk submodule to the shared lwk fork Use the shared lwk fork and add getAddress Oct 14, 2026

@Arvolear Arvolear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear
Arvolear merged commit 1bec454 into master Oct 21, 2026
2 checks passed
@Arvolear
Arvolear deleted the feature/shared-lwk-fork branch October 21, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants