Skip to content

Count explicit coins at every wallet address - #57

Merged
Arvolear merged 4 commits into
masterfrom
fix/explicit-owned-outputs
Oct 22, 2026
Merged

Arvolear merged 4 commits into
masterfrom
fix/explicit-owned-outputs

Conversation

@lilbonekit

Copy link
Copy Markdown
Collaborator
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

Closes #56.

LWK leaves explicit outputs out of balance() and per-transaction balances, so coins sent to the wallet's unconfidential addresses were missing from the token list, activity and snapshot getUTXOs. The fallback reader also dropped everything outside 0/0.

  • Snapshot balances are now summed from the same UTXOs the snapshot returns, and the snapshot and fallback share one reader.
  • Explicit coins are read at every external and change index under their own derivation path.
  • Activity adds explicit inputs and outputs to LWK's per-transaction balance.
  • CI: replaced jetli/wasm-pack-action, which fails with EXDEV when the lwk wasm cache misses, with taiki-e/install-action pinned to wasm-pack 0.14.0.

Max send is unchanged: the wallet's own send flow still spends confidential coins only.

@lilbonekit
lilbonekit requested review from Arvolear and KyrylR October 22, 2026 08:35

@Arvolear Arvolear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear
Arvolear merged commit f6f6c1d into master Oct 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit owned outputs are absent from portfolio balances and getUTXOs snapshots

2 participants