Skip to content

PatternString: treat null values as non-passing #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omsmith merged 1 commit into from
Sep 10, 2026
Merged

PatternString: treat null values as non-passing #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Rules/D2L.CodeStyle.Analyzers.Rule.PatternString/PatternStringAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ ConcurrentDictionary<string, Lazy<Regex>> regexCache
// [PatternString] requires the assigned value to be a compile-time
// constant so that we can evaluate it here.
Optional<object?> constant = valueOperation.ConstantValue;
if( !constant.HasValue ) {
if( !constant.HasValue || constant.Value is null ) {
context.ReportDiagnostic(
Diagnostic.Create(
descriptor: Diagnostics.PatternStringMustBeConstant,
Expand Down
9 changes: 7 additions & 2 deletions tests/D2L.CodeStyle.Analyzers.Test/Specs/PatternStringAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,19 @@ void SinglePatternTests() {
}

void NonConstantValuesAreFlagged() {

#region Non-constant values are flagged as needing to be constant
string variable = "123";

#region Non-constant values are flagged as needing to be constant
Digits _ = new( /* PatternStringMustBeConstant() */ variable /**/ );
Digits _ = /* PatternStringMustBeConstant() */ variable /**/;
_ = (Digits)/* PatternStringMustBeConstant() */ variable /**/;
#endregion

#region null is treated as non-constant
Digits _ = new( /* PatternStringMustBeConstant() */ null /**/ );
Digits _ = /* PatternStringMustBeConstant() */ null /**/;
_ = (Digits)/* PatternStringMustBeConstant() */ null /**/;
#endregion
}

void MultiplePatternTests() {
Expand Down
Loading