fix: GAUD-10626 - Fix mobile height calculations - #7474
Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
approved these changes
Sep 10, 2026
|
🎉 This PR is included in version 3.314.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that calculations are slightly off on my phone, so things weren't sticking at the right spot. Mainly, the divider handle could be scrolled away at the bottom of the screen.
dvhisn't supported in everything we need, so we fallback tovh. This is temporary - once I add Legacy Browser Mode, it'll replace these two values anyways (POC here). Legacy Browser Mode will turn on for browsers that don't support Popover, and Popover support was added after Dynamic Viewport Units. So we should be covered there.