Add @git. section to cable component for um7 esm1p6 build - #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We didn't add an
@git.section to one of thecablebuilds, which led to a failure when building with a non-commit-hash build - see https://github.com/ACCESS-NRI/upstream-spack-packages/actions/runs/32436095811/job/96640684757?pr=7.Spack accepts 40-char git hashes as part of
@and@git., which is why this hasn't shown up in the CI here (which only uses commit hashes for the{{ ref }}. But inaccess-spack-packages(which uses branch refs), it tried to do@main- looking for a particularversion("main")in thepackage.pywhich didn't exist.The PR
@git-style versioning to theum7-basedesm1p6manifest to correctly do branch-based versions.📚 Documentation preview 📚: https://cable--736.org.readthedocs.build/en/736/