Repository navigation
test(updates): dispose orchestrator fixture temp dirs - #403
Merged
Merged
Conversation
The memory-persistence helper created one temp directory per fixture and relied on process.once("exit"), which bun test never runs, so every fixture leaked an orchestrator-intent-memory-* directory.
Register created roots and arm an afterEach on the first fixture to remove them. Removal is idempotent and limited to registered roots; the new test proves the disposer removes its own directories and leaves an unowned sibling alone.
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The orchestrator test helper now removes every temp directory it creates (a disposer run from the consuming tests' cleanup), instead of relying on a process exit handler that
bun testnever runs.Why
Every fixture leaked an empty
orchestrator-intent-memory-*directory; the package-scope race sweep builds thousands of fixtures per run.Verification
A leak probe shows N leaked directories before and none after; a mutant that drops the registration turns the probe red; only directories the helper itself created are removed; gates pass.
Limits
Test helper only; no product code.