Skip to content

test(backend): widen the fresh-process clock child deadline for cold starts - #405

Merged
andrescera merged 1 commit into
mainfrom
test/clock-restart-cold-start-headroom
Oct 22, 2026
Merged

andrescera merged 1 commit into
mainfrom
test/clock-restart-cold-start-headroom

Conversation

@andrescera

Copy link
Copy Markdown
Member

What

The credential-clock-restart test's fresh-process child deadline goes from 15 s to 45 s and its derived per-test hang budget from 50 s to 145 s. Assertions, the child source and product code are byte-identical.

Why

The independent review of the stabilising change found that the first child of a fresh checkout needs about four times the CPU of a warm one under heavy contention, so the 15 s deadline fired in 1 of 10 runs and 4 of 4 fresh checkouts there. It fired loudly (a correctly attributed deadline, never a false pass), but a flake is a flake.

How to verify

Measured cold worst case on a fresh checkout under the reviewer's contention recipe: 20.2 s, so the new deadline has 2.2x headroom. On fresh checkouts under that recipe the old deadline failed 2 of 8 and the new one 0 of 8. A never-exiting child still fails loudly at 45 s with exit 137, and removing the deadline is caught by the per-test budget.

Risks

Test-only. A real hang is detected about 30 s later than before.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 208a4818-2728-49bf-b975-941df00f3705

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andrescera
andrescera merged commit 9c7a0b8 into main Oct 22, 2026
18 checks passed
@andrescera
andrescera deleted the test/clock-restart-cold-start-headroom branch October 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant