Repository navigation
test(backend): widen the fresh-process clock child deadline for cold starts - #405
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The credential-clock-restart test's fresh-process child deadline goes from 15 s to 45 s and its derived per-test hang budget from 50 s to 145 s. Assertions, the child source and product code are byte-identical.
Why
The independent review of the stabilising change found that the first child of a fresh checkout needs about four times the CPU of a warm one under heavy contention, so the 15 s deadline fired in 1 of 10 runs and 4 of 4 fresh checkouts there. It fired loudly (a correctly attributed deadline, never a false pass), but a flake is a flake.
How to verify
Measured cold worst case on a fresh checkout under the reviewer's contention recipe: 20.2 s, so the new deadline has 2.2x headroom. On fresh checkouts under that recipe the old deadline failed 2 of 8 and the new one 0 of 8. A never-exiting child still fails loudly at 45 s with exit 137, and removing the deadline is caught by the per-test budget.
Risks
Test-only. A real hang is detected about 30 s later than before.