Repository navigation
parser cbor BUGFIX negative integers below INT64_MIN - #2597
Open
affan-arch wants to merge 1 commit into
Open
affan-arch wants to merge 1 commit into
affan-arch wants to merge 1 commit into
Conversation
Member
|
I have changed the target branch to |
affan-arch
force-pushed
the
cbor-negint-range
branch
from
October 24, 2026 06:00
9228315 to
8746f82
Compare
Author
|
rebased on devel, the conflict was just test_negint sitting next to the new test_invalid_input in test_cbor.c, kept both. will target devel from now on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lydcbor_item_to_string()converted a CBOR negative integer-1 - nas-1 - (int64_t)n, which wraps for n > INT64_MAX, so e.g.-18446744073709551611was accepted into auint8leaf as5(and-2^64as0); printing the exact value from theuint64_tinstead lets the type plugins reject it the same way they do for JSON/XML, andtest_negintcovers both cases.