53 fix wfh data input columns in trip generation modelpy#54
Merged
nrferguson merged 2 commits intoJul 24, 2026
Merged
Conversation
change logic to read in the first three columns only of that file; so regardless of how many columns the input file has, it will just grab the first 3 it needs
The script only actually needs the first two columns so I made that update
tinleycraig
approved these changes
May 26, 2026
tinleycraig
left a comment
tinleycraig
left a comment
Contributor
There was a problem hiding this comment.
These changes look good.
Collaborator
|
Database/trip_generation/trip_generation_model.py does not exist on the develop branch. It was removed by commit dc23731. @tk-oleary can you help us understand what's going on? |
Collaborator
|
The commit was unintentional. Resolved the conflicts by resetting develop to a commit before the file was deleted. |
nrferguson
deleted the
53-fix-wfh-data-input-columns-in-trip_generation_modelpy
branch
July 24, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated code to read in only the first two columns of the WFH file since that's all the script needs; this way the input file can have as many columns as it wants but it will only read in the 2 it needs