Skip to content

add the --load argument - #1779

Open
annamontare-nava wants to merge 3 commits into
masterfrom
anna/add-docker-load-arg
Open

annamontare-nava wants to merge 3 commits into
masterfrom
anna/add-docker-load-arg

Conversation

@annamontare-nava

Copy link
Copy Markdown
Contributor

JIRA Ticket:
n/a

What Does This PR Do?

Adds the --load arguments to build steps.

Otherwise an error is given that the built image will only be available
in the build cache, and the build steps fail.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • any other changes we need to make?

Validation

  • If you remove all your containers and images, does make build-local still work?

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

annamontare-nava and others added 3 commits October 26, 2026 12:59
…s of docker

Otherwise an error is given that the built image will only be available
in the build cache, and the build steps fail.
@jimmyfagan jimmyfagan self-assigned this Oct 28, 2026

@jimmyfagan jimmyfagan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After installing buildx, this seems to work fine! We should consider holding off on merging until others on the team confirm that the --load option does work with buildx, otherwise this could be disruptive. Maybe an 11th tomorrow, or an eng sync topic next week?

@annamontare-nava

Copy link
Copy Markdown
Contributor Author

After installing buildx, this seems to work fine! We should consider holding off on merging until others on the team confirm that the --load option does work with buildx, otherwise this could be disruptive. Maybe an 11th tomorrow, or an eng sync topic next week?

Added to eng snyc!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants