Skip to content

CodeBuild test runner in VPC and fix OpenTofu runner - #1782

Merged
noor1027 merged 4 commits into
masterfrom
Noor1027/BB2-5311-codebuild-runner-in-vpc
Oct 28, 2026
Merged

noor1027 merged 4 commits into
masterfrom
Noor1027/BB2-5311-codebuild-runner-in-vpc

Conversation

@noor1027

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BB2-5311

What Does This PR Do?

  • Puts CodeBuild in the VPC: Attaches the test runner to private subnets so integration tests can resolve internal *.cmscloud.local endpoints.
  • Fixes OpenTofu CI Failures: Removes the problematic node wrapper shim causing tofu init crashes and forwards failure logs to CloudWatch.
  • Guards ALB SSL Listener: Adds ignore_changes = [certificate_arn] on the :443 listener to prevent unexpected certificate swaps on apply.
  • Cleans Up Task Secrets: Removes unused SLSx development credentials from the ECS task environment

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

  • tofu plan ran successfully with expected diffs.
  • CloudWatch logs verified for OpenTofu test runs.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • [ X] No migrations

put the CodeBuild test runner in the VPC, drop the tofu_wrapper node
shim that was killing init on the runners, ship init failures to
CloudWatch, stop applies from swapping the ALB cert (ignore_changes),
and drop unused SLSx secrets from the api task
@noor1027
noor1027 force-pushed the Noor1027/BB2-5311-codebuild-runner-in-vpc branch from ccb5dc0 to 6ec8d69 Compare October 27, 2026 15:53
@noor1027
noor1027 marked this pull request as ready for review October 28, 2026 12:57
@ryan-morosa ryan-morosa self-assigned this Oct 28, 2026
Comment thread ops/services/00-bootstrap/README.md
Comment thread ops/services/00-bootstrap/README.md

@ryan-morosa ryan-morosa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@noor1027
noor1027 merged commit f96dcac into master Oct 28, 2026
18 checks passed
@noor1027
noor1027 deleted the Noor1027/BB2-5311-codebuild-runner-in-vpc branch October 28, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants