Skip to content

only create on call composite monitors on sandbox and prod - #1785

Open
annamontare-nava wants to merge 2 commits into
masterfrom
anna/no-on-call-composite-for-test
Open

annamontare-nava wants to merge 2 commits into
masterfrom
anna/no-on-call-composite-for-test

Conversation

@annamontare-nava

Copy link
Copy Markdown
Contributor

JIRA Ticket:
n/a

What Does This PR Do?

This fixes an issue introduced in a previous PR where on call composite monitors are attempted to be created in test, even though there are no on call monitors there.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

  • Do a tofu plan on test and ensure that there are no on call monitors in the plan.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants