Repository navigation
bb2-5332 add logging - #1786
Open
BenColeCode wants to merge 5 commits into
Open
bb2-5332 add logging#1786BenColeCode wants to merge 5 commits into
BenColeCode wants to merge 5 commits into
Conversation
…/CMSgov/bluebutton-web-server into bencolecode/bb2-5332-add-logging
| verify=self.verify_ssl_internal, | ||
| ) | ||
|
|
||
| logger.info({'Status of Request':response.status_code}) |
Contributor
There was a problem hiding this comment.
Let's update this so it aligns with how other logs output 'response_code', and also some indication that it's the status_code for the relationships retrieval call
JamesDemeryNava
requested changes
Oct 28, 2026
JamesDemeryNava
left a comment
Contributor
There was a problem hiding this comment.
Log appears as expected, let's add some more detail and conform with logging patterns.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-5332
What Does This PR Do?
Adds status code logging to relationships endpoint
What Should Reviewers Watch For?
Does this log the status of requests?
If you're reviewing this PR, please check for these things in particular:
Validation
make a request to the endpoint and check the logs
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)