Skip to content

Closes #1928: Remove legacy registry=true support#1935

Open
david-rocca wants to merge 1 commit into
2.8.4-releasefrom
cleanup/dr_1928
Open

Closes #1928: Remove legacy registry=true support#1935
david-rocca wants to merge 1 commit into
2.8.4-releasefrom
cleanup/dr_1928

Conversation

@david-rocca

Copy link
Copy Markdown
Collaborator

Closes #1928

Summary

Removes the abandoned query-parameter registry mode from legacy user and organization endpoints. Registry behavior is now exposed only through explicit /api/registry/... routes.

Changes

  • Removed handleRegistryParameter middleware and all legacy route usage.
  • Removed registry query parsing, validation, Swagger/OpenAPI documentation, tests, and stale comments.
  • Legacy /api/users now rejects ?registry=true and always returns the legacy user format.
  • Removed registry-mode branches from legacy organization and user controller handlers.
  • Preserved the shared registry behavior required by:
    • GET /api/registry/org/:shortname/id_quota
    • PUT /api/registry/org/:shortname/user/:username/reset_secret
  • Replaced opaque repository mode booleans in the org controller with named legacy/registry format constants.
  • Updated the integration-test document DB host to localhost.

Verification

  • npm run test:integration
    • 480 passing

Comment thread api-docs/openapi.json
"servers": [
{
"url": "https://cveawg-dev.mitre.org/api"
"url": "urlplaceholder"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not want this URL here anymore?

Comment thread api-docs/openapi.json
"description": "Returns information about all organizations, along with pagination fields if results span multiple pages of data",
"content": {
"application/json": {
"schema": {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still implies oneOf these two schemas is possible, aren't all responses just the LEGACY_ORG_FORMAT now?

Comment thread api-docs/openapi.json
"description": "Returns information about the organization created",
"content": {
"application/json": {
"schema": {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above on line 3355 for the accompanying GET request. This still implies oneOf these two schemas is possible, aren't all responses just the LEGACY_ORG_FORMAT now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants