Accept Shape in Solid.fillet/chamfer - #2105
Open
DavidMStraub wants to merge 3 commits into
Open
DavidMStraub wants to merge 3 commits into
DavidMStraub wants to merge 3 commits into
Conversation
Mixin3D.fillet/chamfer now take edgeList: Shape | Iterable[Edge]. A Shape is normalized with _get_edges(edges.edges()), as the free functions do. This fixes mypy/Pyright errors when passing Shape.edges(...) and a runtime crash when the selection is a single Edge. Fixes CadQuery#2104 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2105 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 30 30
Lines 9589 9593 +4
Branches 1439 1440 +1
=======================================
+ Hits 9187 9191 +4
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adam-urbanczyk
approved these changes
Oct 4, 2026
adam-urbanczyk
left a comment
adam-urbanczyk
left a comment
Member
There was a problem hiding this comment.
Thanks, tweaked naming to match existing helpers.
Co-authored-by: AU <adam-urbanczyk@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixin3D.fillet/chamfer now take edgeList: Shape | Iterable[Edge]. A Shape is normalized with _get_edges(edges.edges()), as the free functions do. This fixes mypy/Pyright errors when passing Shape.edges(...) and a runtime crash when the selection is a single Edge.
Fixes #2104