Repository navigation
FIREFLY-2117: Restrict spectral charts xaxis range when spectral lines go outside data range - #2040
Merged
Merged
Conversation
loitly
approved these changes
Oct 9, 2026
loitly
left a comment
Contributor
There was a problem hiding this comment.
Tested and it worked as described. Changes look good. Ready to go.
Contributor
|
this is amazing! works great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-2117
Spectral lines far outside the data (e.g. Herschel far-IR lines on a 5–9 µm Spitzer spectrum) stretched the x axis to ~650 µm, since Plotly counts shapes in autorange with no per-shape opt-out. Added
makeShapesAutorangeLayout(ChartUtil.js), which clips x autorange to the padded data extent using Plotly'sautorangeoptions.clipmin/clipmax, so autorange (initial plotting, 1x button, filter resets) still fits the data while lines beyond it still show when zoomed out.Testing
https://firefly-2117-restrict-sp-line-range.irsakubedev.ipac.caltech.edu/firefly/
Spitzer_IRS_SL_PBCD-topocenter.votin ticket) -> Spectral lines dialog -> load Spitzer PAHFIT + Herschel HSPOT -> x axis should fit the data, not the lines unlike the screenshot in the ticket.wavelength < 6.5): axis shrinks to the filtered data