Repository navigation
Firefly-2119: Tooltip Design and Bug Fixes - #2042
Open
aventura121 wants to merge 8 commits into
Open
aventura121 wants to merge 8 commits into
aventura121 wants to merge 8 commits into
Conversation
aventura121
marked this pull request as ready for review
October 15, 2026 16:03
aventura121
marked this pull request as draft
October 15, 2026 16:04
aventura121
marked this pull request as ready for review
October 15, 2026 16:16
Contributor
|
wow, this is really impressive! works great as far as i can see! |
loitly
approved these changes
Oct 15, 2026
loitly
left a comment
Contributor
There was a problem hiding this comment.
The changes look great. I like the simplicity of this approach.
I noticed one minor issue (which may already exist). When I focus on a filter box, the tooltip appears as expected. However, after moving the mouse away and using Tab to navigate to other filter boxes, the tooltip continues to pop up for each one, even though the mouse is no longer hovering over any of them.
If it's an easy fix, could you include it in this PR? Not a big deal if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2119 Tooltip User Experience/Design Improvements
Description
This pull requests addresses the design and state management issues seen below, characterized by the tooltips rendering on hover, and then duplicating or overlapping on scroll or changing focus; and the tooltips in the table dropdown often carrying no information (i.e. they are redundant).
Existing Column Tooltip Pattern
Existing Filter Tooltip Pattern
Existing Table Options Tooltip Pattern
Existing Redundant Tooltip Pattern
Approach
For the filter boxes, the TAP constraint cells, and the Table Options column cells, the tooltip shows only while the input has focus, and moving the cursor off the box closes it. The cells also track their row index to handle scrolling.
For the TAP Project and Tables dropdowns, the tooltip shows only when it adds information: when an option's description is cut at the 140-character limit, the tooltip shows the full text.
Testing/Validation
Build: https://firefly-2119-tooltip-on-focus-3.irsakubedev.ipac.caltech.edu/firefly
Filter and Constraints Help Syntax
The same behavior is expected on the contraints' cells, and in the table options view.
Tables Dropdown
In the table selection dropdown, we can view a source like GAVO, which has long descriptions for its tables, and see we still render such tooltips:
GAVO screenshot (continue to show tooltip because the description is long and carries information)
Where the options' text is fully visible by default, we do not render the tooltip:
NED screenshot (do not show tooltip because there is no additional information)