Repository navigation
db: every table LOGGED; tests and the release fake target rapid - #248
Merged
Merged
Conversation
20261013-01-logged-tables.sql sets every UNLOGGED table in public to LOGGED and replaces the three child-table functions without their SET UNLOGGED line. The 2026-10-02 unclean stop on rapid-db emptied every UNLOGGED relation while result sets still read complete. The persistence assertions in tests/db follow, and the release fake and tests name the one database, `rapid`, that the rebuild moves into. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efault Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the 2026-10-13 Postgres fresh start: rapid-db's two databases are dropped and one
rapidis rebuilt from this stream, every table LOGGED.Why. On 2026-10-02 rapid-db's postgres stopped uncleanly. Crash recovery reset every UNLOGGED relation, so the sources, merges and astroobjects child tables came back empty while
result_setsstill read complete. Re-running load was a silent no-op. (Probe: all 279 UNLOGGED files in the oldrapid_rebuildhad mtime 2026-10-02 18:40:45 UTC.)What.
database/migrations/20261013-01-logged-tables.sql, additive (applied files are never edited):publictable LOGGED. On a fresh database that issourcesandxsources; on an older one it also covers existing children.create_sources_child_table,create_field_object_tablesandcreate_astroobjectsmeta_child_tableare replaced with bodies byte-identical to their latest definitions (20260923-09, 20260924-04) minus theSET UNLOGGEDline. Owner and REVOKE are restated as those files do.relpersistenceassertions intests/dbchange fromutop.FakeReleaseDBdefaults todbname="rapid", andtest_release_cutandtest_recoveryuse the same name.database_targetitself comes from the connection, so no code default changes.Considered and not done: squashing the 32 migrations into one new baseline while no applied database survives. It's a cleaner end state but touches the CI drift check and the release hook; that's for the team's first review.
Verification: CI (
db-migrations.ymlapplies from empty and re-applies; the test suite runs against the result).🤖 Generated with Claude Code