Fix: Crop area sits under the system bars on edge-to-edge - #705
Open
msinghal34 wants to merge 1 commit into
Open
msinghal34 wants to merge 1 commit into
msinghal34 wants to merge 1 commit into
Conversation
CropImageView fills the whole window, and for an app targeting API 35+ the content view is the whole window too, so the action bar draws over the top of the crop area and the navigation bar over the bottom. Portrait usually hides it, because the image is width-limited there and centres into the vertical slack; in landscape the crop window is height-limited, reaches both edges, and puts its top corner handles under the toolbar with the bottom pair under the navigation bar, where they cannot be dragged. fitsSystemWindows makes the view consume the insets ActionBarOverlayLayout already dispatches to it, the action bar's height included. It is a no-op before edge-to-edge, where the decor fits system windows itself and there is no inset left to consume, so older apps are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CropImageView fills the whole window, and for an app targeting API 35+ the content view is the whole window too, so the action bar draws over the top of the crop area and the navigation bar over the bottom. Portrait usually hides it, because the image is width-limited there and centres into the vertical slack; in landscape the crop window is height-limited, reaches both edges, and puts its top corner handles under the toolbar with the bottom pair under the navigation bar, where they cannot be dragged.
fitsSystemWindows makes the view consume the insets ActionBarOverlayLayout already dispatches to it, the action bar's height included. It is a no-op before edge-to-edge, where the decor fits system windows itself and there is no inset left to consume, so older apps are unaffected.