Skip to content

fix: Sounds with start offset overflow frame #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StickmanRed wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: Sounds with start offset overflow frame #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions engine/src/gui/Frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,11 @@ Wick.GUIElement.Frame = class extends Wick.GUIElement {
var frameLengthMS = (1 / framerate) * this.model.length * 1000;

var frameLengthPx = this.model.length * this.gridCellWidth;
var startPx = (this.model.soundStart / soundLengthMS) * 1200;
var cropPx = (frameLengthMS / soundLengthMS) * 1200; // base waveform image size: 1200px

// Determining Pxls/milliseconds to shift waveform.
var msPerFrame = 1000/framerate;
var pxPerMS = msPerFrame/this.gridCellWidth;
var shiftSoundStart = -(this.model.soundStart * (1/pxPerMS));

var volumeCropAmt = (waveform.height/2)*(1-(1/this.model.soundVolume));
ctx.drawImage(waveform, 0, volumeCropAmt, cropPx, waveform.height-volumeCropAmt*2, shiftSoundStart, 0, frameLengthPx, this.gridCellHeight);
ctx.drawImage(waveform, startPx, volumeCropAmt, cropPx, waveform.height-volumeCropAmt*2, 0, 0, frameLengthPx, this.gridCellHeight);
} else if (this.model.tweens.length > 0) {
// Tweens

Expand Down