fix: Clicking "Try it!" welcome button on mobile closes autosave modal - #220
Open
StickmanRed wants to merge 1 commit into
Open
StickmanRed wants to merge 1 commit into
StickmanRed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So you press the "Try it!" button, which triggers an
onTouchStartevent. The welcome modal closes and the autosave modal opens. But because the button was a child of the overlay element, you've technically pressed the overlay. And then releasing triggers the overlay element'sclickevent, closing the autosave modal before you have a chance to interact with it.This fix reuses the
useClickEventproperty of buttons from #90 so that theclickevent gets captured by the "Try it!" button, not the outside overlay.Testing
Checklist