test(chrome-extension): verify WebRTC session description formatting - #2177
Closed
gcoinstash-cmd wants to merge 14 commits into
Closed
test(chrome-extension): verify WebRTC session description formatting#2177gcoinstash-cmd wants to merge 14 commits into
gcoinstash-cmd wants to merge 14 commits into
Conversation
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
|
||
| it("throws error when session description is null or undefined", async () => { | ||
| const { toSessionDescriptionInit } = await import("./webrtc"); | ||
| expect(() => toSessionDescriptionInit(null)).toThrow( |
Contributor
There was a problem hiding this comment.
This test claims coverage for both null and undefined, but its only assertion passes null. An independent regression in undefined-input handling would therefore remain undetected while the test name implies that case is covered.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 83
Comment:
**Undefined case is not tested**
This test claims coverage for both `null` and `undefined`, but its only assertion passes `null`. An independent regression in undefined-input handling would therefore remain undetected while the test name implies that case is covered.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Greptile Summary
This PR expands unit coverage for Chrome-extension WebRTC session-description formatting and shared recorder-core capture/error utilities.
Confidence Score: 4/5
The PR appears safe to merge, with one non-blocking test-accuracy issue where undefined input is named but not exercised.
The production code is unchanged and the new tests resolve against source correctly; only the WebRTC missing-description test overstates the edge cases it verifies.
Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(chrome-extension): verify WebRTC se..." | Re-trigger Greptile