test(chrome-extension): verify WebRTC session description formatting - #2181
Open
gcoinstash-cmd wants to merge 18 commits into
Open
test(chrome-extension): verify WebRTC session description formatting#2181gcoinstash-cmd wants to merge 18 commits into
gcoinstash-cmd wants to merge 18 commits into
Conversation
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
Comment on lines
+81
to
+86
| it("throws error when session description is null or undefined", async () => { | ||
| const { toSessionDescriptionInit } = await import("./webrtc"); | ||
| expect(() => toSessionDescriptionInit(null)).toThrow( | ||
| "Missing session description", | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
This test claims to cover both null and undefined, but only invokes the helper with null. An undefined-input regression would therefore pass while the suite continued to report that case as covered.
Suggested change
| it("throws error when session description is null or undefined", async () => { | |
| const { toSessionDescriptionInit } = await import("./webrtc"); | |
| expect(() => toSessionDescriptionInit(null)).toThrow( | |
| "Missing session description", | |
| ); | |
| }); | |
| it.each([null, undefined])( | |
| "throws error when session description is %s", | |
| async (description) => { | |
| const { toSessionDescriptionInit } = await import("./webrtc"); | |
| expect(() => | |
| toSessionDescriptionInit(description as RTCSessionDescription | null), | |
| ).toThrow("Missing session description"); | |
| }, | |
| ); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 81-86
Comment:
**Undefined Case Is Not Tested**
This test claims to cover both `null` and `undefined`, but only invokes the helper with `null`. An undefined-input regression would therefore pass while the suite continued to report that case as covered.
```suggestion
it.each([null, undefined])(
"throws error when session description is %s",
async (description) => {
const { toSessionDescriptionInit } = await import("./webrtc");
expect(() =>
toSessionDescriptionInit(description as RTCSessionDescription | null),
).toThrow("Missing session description");
},
);
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Greptile Summary
Adds unit coverage for Chrome-extension WebRTC session-description conversion and shared recorder utilities.
Confidence Score: 4/5
The PR appears safe to merge, with one non-blocking test-coverage description issue.
The added assertions align with current helper behavior, but the WebRTC missing-description test claims undefined coverage without exercising that input.
Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(chrome-extension): verify WebRTC se..." | Re-trigger Greptile