feat(chrome-extension): streamline recording bar into compact draggable badge on recording start - #2210
Merged
richiemcilroy merged 8 commits intoSep 3, 2026
Conversation
…le badge on recording start
Comment on lines
+248
to
+256
| const interval = window.setInterval(() => { | ||
| cur -= 1; | ||
| if (cur <= 0) { | ||
| window.clearInterval(interval); | ||
| setCountdownValue(null); | ||
| return; | ||
| } | ||
| setCountdownValue(cur); | ||
| }, perNum); |
Contributor
There was a problem hiding this comment.
Hidden countdown interval survives
When overlay-hide arrives before the countdown finishes, it clears only countdownValue while this interval continues running; the next tick restores the badge, and a subsequent countdown can race with the stale timer and display incorrect values.
Knowledge Base Used: Mobile and browser capture clients
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/content/recording-bar.tsx
Line: 248-256
Comment:
**Hidden countdown interval survives**
When `overlay-hide` arrives before the countdown finishes, it clears only `countdownValue` while this interval continues running; the next tick restores the badge, and a subsequent countdown can race with the stale timer and display incorrect values.
**Knowledge Base Used:** [Mobile and browser capture clients](https://app.greptile.com/cap/-/custom-context/knowledge-base/capsoftware/cap/-/docs/mobile-and-browser-capture-clients.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Contributor
Author
…answer type narrowing
Contributor
Author
…to active tab, and smooth badge dragging
Contributor
Author
…lt device and fix background service worker preview check
Contributor
Author
…trols, blur tool, and camera preview
…ion and broadcast countdown to tabs
…th hover reveal with generous hitbox grace period
Contributor
Author
Member
|
hey @greptileai please re-review the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR streamlines the Chrome Extension recording overlay by removing the redundant floating iframe panel from page injection and contracting the
bottom bar into a compact, draggable circular Cap badge with an in-badge countdown when recording starts.
Key Changes
RecorderPanelOverlayinjection into web pages so only the sleek bottom "Ready to record" bar appears when opening the recorder.loadSharedUiState.ring animation (
overlay-countdown).isPointerDownRefguard).Testing Done
pnpm exec biome check --write <files>pnpm --filter=@cap/chrome-extension test(18/18 tests passing)vite buildfor all extension targetsGreptile Summary
The PR replaces the expanded Chrome recording rail with a compact draggable badge and moves the countdown into that badge.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains from the previously reported countdown interval or build issues.
Important Files Changed
Reviews (7): Last reviewed commit: "feat(chrome-extension): harden camera st..." | Re-trigger Greptile