Repository navigation
improve: revamp desktop styles - #4387
Open
richiemcilroy wants to merge 72 commits into
Open
richiemcilroy wants to merge 72 commits into
richiemcilroy wants to merge 72 commits into
Conversation
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · 8 credits · Review details |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
@greptileai review |
Member
Author
|
@greptileai review |
Member
Author
|
@greptileai review |
Member
Author
|
@greptileai review |
… for the recording's platform A caption's corner resize follows the position the renderer drew it at, its own override included. The timeline builds its keys for the platform the recording was made on, as the preview and exports draw them.
New, in the library and the File menu, opens an empty Studio project with no recording: an animated background and a clip that runs up to ten minutes, to build a video from music, keys, text and images. The project carries a blank flag, so its placeholder display is never drawn, as for audio-only recordings, and it takes 28 KB on disk. Clicking the keyboard track adds a key press by hand. Its text can be a shortcut in words (cmd+shift+p) or typed text, and it strikes and sounds its keys like a recorded one. Regenerating from a recording keeps keys added by hand, and a split of one stays hand-made.
This comment has been minimized.
This comment has been minimized.
The Keyboard tab has a composer: type a sentence or a shortcut in words (cmd+shift+p) and press Enter, and it shows at the playhead, sized to be typed and read, with the playhead moving on so the next entry follows. Retyping a key added by hand grows it to fit. Animated backgrounds gain a style: an ordered dither of their own palette, crisp at every size, or the smooth wash they had. Dither is the default for a new animated background; one saved before keeps its smooth look. A dither has a cell size to tune and no lighting or grain; picking a template or a shuffle keeps the style chosen.
…e, and preview typed keys Keys can sit on the frame's middle row: left, centre or right. The Position dropdown becomes a small frame with nine spots, the chosen one holding a key, so the choice reads as the video will. The key composer previews what Enter will add as it will show, and says when a + did not make a shortcut, so a typo reads before it lands on the video.
…ly controls from blank projects The position frame takes the panel's width at the video's shape. A blank project has no recording to generate key presses from, so the Keyboard tab leaves out the generate button and its empty state.
Member
Author
|
@greptileai review |
The key composer's Show As picks how a typed sentence appears: a key per word, typed out letter by letter (the default), a key per keystroke, or the whole sentence on one key. The pieces follow each other back to back from the playhead, each held a beat, the last held to be read. Text typed into the composer types out whether or not recorded typing is shown.
A word typed into the key composer arrives a letter at a time, each on a key of its own with its capital printed, struck and springing back as the row slides to make room. A beat after its last letter, or as soon as a space ends it, the letters glide together and the word's key grows out of the span they covered. Each word is held long enough to come together and be read.
Member
Author
|
@greptileai review |
…how, and let Bottom Center replace above-captions Splitting a key added by hand keeps both halves hand-made in the keyboard track's own split, so the second half keeps its sounds and survives regenerating. Recorded presses sound only under recorded keys, not under a key added by hand over them. A project saved with keys above the captions lights Bottom Center in the picker, and clicking it now writes it.
Member
Author
|
@greptileai review |
A run of keys typed into the composer that is longer than the clip is scaled by the length it asked for, so every key lands inside the clip in order instead of the last ones being cut or stored inverted past its end.
…and keep earlier letters' print still Typed keys with Show As set to Keys keep a shortcut with Shift (shift+tab) on one key press. A space struck on its own in the composer shows as the space bar instead of nothing. While a word types out, only the letter just struck dips, its print with it.
Member
Author
|
@greptileai review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We are revamping the desktop app's styles. This pass gives the editor a calmer, roomier layout, a new timeline and smoother controls, and the shared components now read as one piece in light and dark.
Everything is painted with fills, gradients and shadows. There is no backdrop blur, so it looks the same on macOS, Windows and Linux and costs nothing per frame.
What changed
AppleFontSmoothingpreference to 0 at launch, before gpui reads it. Windows and Linux renderers have no dilation, so they are unchanged.crates/rendering/assets/fonts/keycaps) so exports match on every platform. Projects saved before this keep the classic label; new projects start with their platform's keys. The Keyboard tab picks style and theme from tiles that preview each key.crates/editor/assets/input-sounds/README.md), mono Opus, 326 KB in all, decoded once and only when a pack is first used. With both toggles off the audio is byte-identical to before and no pack is decoded. With them on, a 1024-frame block renders in 1.4 us on average (8.5 us p99), and a 1080p export takes no measurably longer.blankflag besideaudioOnly, so its two-frame placeholder display (28 KB on disk) is never drawn, and the editor keeps its normal preview and exports.cmd+shift+p), and press Enter. It shows at the playhead, sized to be typed and read, and the playhead moves on so the next entry follows. Show As picks how a sentence appears: a key per word (the default), a key per keystroke, or the whole sentence on one key. A word arrives a letter at a time, each on its own key, struck and springing back as the row slides to make room, then its letters glide together and the word's key grows out of them. A live preview shows the keys before they land, and says when a+did not make a shortcut. Clicking the keyboard track also adds a key. Keys added by hand strike and sound like recorded ones, survive regenerating from a recording, and grow to fit when retyped.Screenshots
In each image the top half is before and the bottom half is after.
Editor, dark

Editor, light

Timeline with many tracks, dark

Timeline with many tracks, light

Sidebar: the Cursor tab before and after, then the Background tab before and after


Testing
cargo test --bin cap-gpui: 2112 passed, 0 failed locally, plus 522 rendering and 337 project tests, and the translation catalogue checks pass. New tests cover the hover fade timing, the pill glide state, centring a source pill, wheel and trackpad routing over the source row, label placement around holds, and contrast for every track's labels, values and badges in both themes.

Confidence Score: 5/5
No new merge-blocking issue was found in the follow-up changes.Summary
This PR refreshes desktop styling and adds keycaps, input sounds, blank projects, and built-in looks. The latest changes refine composed keys and remove an unused position menu.
No new independent findings. The earlier overlapping-caption thread was manually resolved without explanation.
Reviews (35) · Last reviewed commit: "fix: keep shift shortcuts whole, show a ..." · Reviewed by Greptile