fix export query for typeorm 1; await call to avoid crash - #3299
Open
bcb37 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the analytics CSV export path to be compatible with TypeORM 1.x and to avoid export crashes caused by an un-awaited async call.
Changes:
- Await
sendExportData(...)soexportCSVData(...)properly propagates failures instead of creating unhandled promise rejections. - Update the export log query to use
getRawMany()(instead of.execute()) and adjust how thelogs.userIdfilter is applied.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/backend/src/api/services/AnalyticsService.ts | Awaits the export task to ensure errors propagate correctly and prevent crash/unhandled rejections. |
| packages/backend/src/api/repositories/LogRepository.ts | Updates the export query builder to fetch raw SELECT results correctly under TypeORM 1.x and refines filtering logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.