Skip to content

update startup/shutdown cleanup #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roycpro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update startup/shutdown cleanup #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/phoebus/recceiver/RecceiverApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ public class RecceiverApplication implements CommandLineRunner {
@Value("${recceiver.cf.clean-on-startup:false}")
private String cfCleanOnStartup;

@Value("${recceiver.cf.delete-on-shutdown:true}")
private String cfDeleteOnShutdown;

@jacomago jacomago Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these options mutually exclusive? Maybe it's better to have a config which is a list of enums.

@shroffk shroffk Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not mutually exclusive...kind off...
I think listing them might be too many states.... it might make it even more confusing than what it is
delete-on-startup
mark-inactive-on-startup
do-nothing-on-startup
delete-on-shutdown
mark-unknown-on-shutdown
do-nothing-on-shutdown

I think I like the current:
one flag for startup, one for shutdown, and one which describes if channels should be deleted

@roycpro roycpro Oct 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I would prefer to keep the 3 parameters.

@Value("${recceiver.cf.clean-on-shutdown:true}")
private String cfCleanOnShutdown;

@Value("${recceiver.cf.alias-enabled:true}")
private String cfAliasEnabled;
Expand Down Expand Up @@ -236,7 +236,7 @@ private Map<String, String> buildProcessorOptions() {
options.put("recceiver.cf.password", cfPassword);
options.put("recceiver.cf.delete-on-clean", cfDeleteOnClean);
options.put("recceiver.cf.clean-on-startup", cfCleanOnStartup);
options.put("recceiver.cf.delete-on-shutdown", cfDeleteOnShutdown);
options.put("recceiver.cf.clean-on-shutdown", cfCleanOnShutdown);
options.put("recceiver.cf.alias-enabled", cfAliasEnabled);
options.put("recceiver.cf.infotags", cfInfoTags);
options.put("recceiver.cf.environment-vars", cfEnvironmentVars);
Expand Down
Loading