Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Java 25 source/target settings conflict with JDK 21 in both CI workflows and Docker images, causing build failures and preventing the container runtime from loading Java 25 classes.
1 open issue
What changed in this PR
This PR upgrades Recceiver to Spring Boot 4.1 and JDK 25, and changes ChannelFinder cleanup to use batch deletion.
Changes:
- Updates build settings, annotation imports, and hex utilities for the platform migration.
- Adds configurable ChannelFinder HTTP timeouts, batch deletion, and deletion-enabled cleanup defaults.
- Reuses virtual-thread factories and adds processor initialization and cleanup logging.
| File | Description |
|---|---|
src/test/java/org/phoebus/recceiver/SimpleTest.java |
Replaces JAXB hex conversion with HexFormat. |
src/main/resources/application.properties |
Adds HTTP timeout configuration and enables deletion during cleanup. |
src/main/java/org/phoebus/recceiver/spi/RecSyncProcessorRegistry.java |
Logs processor loading through SPI. |
src/main/java/org/phoebus/recceiver/spi/cf/ChannelFinderHttpStore.java |
Implements batch deletion and configurable request timeouts. |
src/main/java/org/phoebus/recceiver/spi/cf/CFRecSyncProcessor.java |
Passes timeout configuration to the store and logs initialization and cleanup. |
src/main/java/org/phoebus/recceiver/RecceiverApplication.java |
Uses Jakarta lifecycle annotations, forwards timeout settings, and shares a client-thread factory. |
src/main/java/org/phoebus/recceiver/MessageProcessor.java |
Shares a virtual-thread factory for commit dispatch. |
pom.xml |
Targets Java 25 and Spring Boot 4.1, updates dependencies, and pins the compiler plugin. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to spring4 and jdk25
Additionally fixing the delete calls to use the batch delete