Skip to content

feat(i18n): complete Traditional Chinese translations - #948

Open
AlanSyue wants to merge 1 commit into
ChatbotXIO:mainfrom
AlanSyue:codex/upstream-complete-zh-tw
Open

feat(i18n): complete Traditional Chinese translations#948
AlanSyue wants to merge 1 commit into
ChatbotXIO:mainfrom
AlanSyue:codex/upstream-complete-zh-tw

Conversation

@AlanSyue

Copy link
Copy Markdown
Contributor

Summary

  • Complete all 179 missing Traditional Chinese message leaves against the current English catalog.
  • Strengthen shared i18n validation for JSON duplicates, string leaves, ICU syntax, placeholders, selectors, and formatting artifacts.
  • Add an explicit zh-TW exact-parity regression test so future missing or extra keys fail CI.

The catalog now has exact key parity with English: 2,998 / 2,998 leaf messages.

Verification

  • pnpm --filter builder exec vitest run __tests__/i18n-zh-tw-parity.test.ts __tests__/i18n-messages.test.ts — 89/89 passed
  • pnpm --filter builder check-types — passed
  • pnpm --filter builder build — passed
  • Local production-build browser E2E with an isolated temporary database:
    • signed in with the seeded demo account
    • selected 繁體中文 from the user menu
    • verified <html lang="zh-TW">
    • verified the Ads analytics page renders Traditional Chinese labels such as 廣告花費 and 合格潛在客戶
    • verified no raw ads.* translation keys are visible

E2E screenshot

Traditional Chinese Ads analytics E2E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant