AST-172563 Use Docker Hub OIDC federation in release pipeline - #1546
Merged
cx-lior-poterman merged 1 commit intoAug 26, 2026
Merged
Conversation
The release workflow's Docker Hub login step used static username/password credentials via step-security/docker-login-action v4.1.0, which predates OIDC support. Bump the action to v4.5.1 and switch to OIDC federation using vars.DOCKERHUB_USERNAME and secrets.DOCKERHUB_OIDC_CONNECTIONID, which are already configured on the repo's release GitHub Environment. The job already declares environment: release and id-token: write, so no permissions changes are needed. This removes the last static Docker Hub credential from the release pipeline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cx-rakesh-kadu
approved these changes
Aug 25, 2026
cx-sumit-morchhale
self-requested a review
August 25, 2026 07:15
cx-atish-jadhav
approved these changes
Aug 25, 2026
cx-lior-poterman
added a commit
that referenced
this pull request
Aug 26, 2026
…rets (#1549) The Secrets Manager step used the secret's ARN as both the secret-id and implicit alias, which produced env vars like CHECKMARX_PUBLIC_SECRETS_APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 instead of the un-prefixed names the rest of the workflow expects, breaking Apple code-signing cert import. Use a blank alias (leading comma) so env var names match the secret's JSON keys directly. Also removes the now-unused DOCKER_PASSWORD/DOCKER_USERNAME workflow_call secrets (Docker Hub now uses OIDC per #1546) and PERSONAL_ACCESS_TOKEN / GO_BOT_TOKEN, whose only consumer (the Homebrew tap publisher) is commented out in .goreleaser.yml. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login to Docker Hub in the release workflow used a static username/password pair, via docker-login-action v4.1.0 which predates OIDC support.