Skip to content

AST-171789 Fix release workflow secrets aliasing and unused secrets #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-lior-poterman merged 1 commit into from
Aug 26, 2026
Merged

AST-171789 Fix release workflow secrets aliasing and unused secrets #1549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ on:
required: true
COSIGN_PUBLIC_KEY:
required: true
DOCKER_PASSWORD:
required: true
DOCKER_USERNAME:
required: true
PERSONAL_ACCESS_TOKEN:
required: true
S3_BUCKET_NAME:
required: true
S3_BUCKET_REGION:
Expand Down Expand Up @@ -100,7 +94,7 @@ jobs:
uses: step-security/aws-secretsmanager-get-secrets@102b6b2a2528747bcc321bb99ef326d8be7ef58f # v3.0.1
with:
secret-ids: |
${{ secrets.SECRET_MANAGER_SECRET_NAME }}
,${{ secrets.SECRET_MANAGER_SECRET_NAME }}
parse-json-secrets: true
- name: Import Code-Signing Certificates
uses: Apple-Actions/import-codesign-certs@253ddeeac23f2bdad1646faac5c8c2832e800071 #v1
Expand Down Expand Up @@ -183,7 +177,6 @@ jobs:
args: ${{ env.GR_ARGS }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GO_BOT_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
S3_BUCKET_NAME: ${{ secrets.S3_BUCKET_NAME }}
S3_BUCKET_REGION: ${{ secrets.S3_BUCKET_REGION }}
SIGNING_REMOTE_SSH_USER: ${{ secrets.SIGNING_REMOTE_SSH_USER }}
Expand Down
Loading