Skip to content

AST-171789 Remove nightly release workflow, gate release under environment - #274

Merged
cx-lior-poterman merged 1 commit into
mainfrom
ast-171789-remove-nightly-and-gate-release
Aug 31, 2026
Merged

AST-171789 Remove nightly release workflow, gate release under environment#274
cx-lior-poterman merged 1 commit into
mainfrom
ast-171789-remove-nightly-and-gate-release

Conversation

@cx-lior-poterman

Copy link
Copy Markdown
Contributor

Removes nightly.yml, which pushed to main and called release.yml on every commit; now that release.yml requires the release environment's manual approval, those pushes would have blocked on human sign-off. Releases are dispatch-only going forward.

Adds environment: release to release.yml and to delete-dev-releases.yml (it's directly dispatchable and deletes releases/tags, so it needs its own gate).

Note: release.yml calls delete-dev-releases.yml via a pinned SHA, so that path stays ungated until the pin is bumped.

nightly.yml triggered release.yml on every push to main, but release.yml
now requires the `release` environment's human approval, so pushes would
block on manual sign-off. Releases are manual dispatch only now.

Adds `environment: release` to release.yml's release job and to
delete-dev-releases.yml's delete job (the latter is directly dispatchable
and deletes releases/tags, so it needed its own gate since release.yml
invokes it via a reusable-workflow `uses:` job, which can't carry an
environment).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cx-lior-poterman
cx-lior-poterman requested a review from a team August 31, 2026 09:39
@cx-sumit-morchhale
cx-sumit-morchhale self-requested a review August 31, 2026 11:00

@cx-sumit-morchhale cx-sumit-morchhale left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cx-lior-poterman
cx-lior-poterman merged commit 7e6af3d into main Aug 31, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants