ShareSpec.DeleteData — opt-in full subvolume removal (#57)#5
Merged
Conversation
…#57) The live smoke test confirmed DSM shares are btrfs subvolumes, so the safe default delete (`synoshare --del FALSE`, keep data) leaves the subvolume behind. Add an opt-in DeleteData flag (default false) that emits `--del TRUE` for a destructive, data-removing delete. - ShareSpec.DeleteData (default false); reconciler wires it through and labels the plan reason "keep data" vs "incl. data". - Tests for both delete modes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the live smoke test, which confirmed DSM shares are btrfs subvolumes: the reconciler's safe default delete (
synoshare --del FALSE, keep data) leaves the subvolume behind, and plainrmon it fails even as root.ShareSpec.DeleteData(defaultfalse) — opt-in to a destructivesynoshare --del TRUEthat removes the data/subvolume too.keep datavsincl. data.Default behaviour is unchanged (keep data). 🤖 Generated with Claude Code