fix(security): stop leaking DSM credentials (login URL + record ToString)#8
Merged
Merged
Conversation
…ing) Two credential-exposure fixes: 1. LoginAsync sent account + password in the auth.cgi *query string* of a GET, so they landed in DSM access logs, proxy logs, and HttpClient request-URI logging even over TLS (CWE-598). Send the SYNO.API.Auth parameters as a POST form body instead. 2. SynologyOptions and SynologySshOptions are records whose synthesized ToString() printed Password — leaking it into any log/interpolation. Override ToString() to emit `Password = ***`. Adds a regression test asserting the password never appears in ToString(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems (2× MEDIUM)
SynologyApiClient.LoginAsyncsentaccount+passwdin theauth.cgiquery string of a GET, so they landed in DSM access logs, any reverse-proxy logs, andHttpClientrequest-URI logging — even over TLS.record.ToString().SynologyOptionsandSynologySshOptionsare records whose synthesizedToString()printedPassword, leaking it into any log/interpolation.Fixes
SYNO.API.Authparameters as a POST form body (FormUrlEncodedContent, which also handles escaping). DSM 7.x accepts form fields onauth.cgi.ToString()on both records to emitPassword = ***.Adds a regression test asserting the password never appears in
ToString(). Builds clean, tests green (18 passed, 2 skipped).🤖 Generated with Claude Code