Repository navigation
test: use assert.strictEqual for equality checks - #3300
Merged
Merged
Conversation
Replace `assert.ok(a === b)` and `assert.ok(a !== b)` with `assert.strictEqual(a, b)` and `assert.notStrictEqual(a, b)`, so that a failure shows both values. `WaitForHelper.test.ts` uses `assert.fail()` behind an `if` instead, because the code after the check relies on the narrowed type and `assert.notStrictEqual` does not narrow. This matches the DevTools `prefer-assert-strict-equal` ESLint rule.
OrKoN
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3299.
Replaces
assert.ok(a === b)andassert.ok(a !== b)withassert.strictEqual(a, b)andassert.notStrictEqual(a, b)in 5 test files, so that a failure shows both values.WaitForHelper.test.tsusesassert.fail()behind anifinstead, because the code after the check relies on the narrowed type andassert.notStrictEqualdoes not narrow.This matches the DevTools
prefer-assert-strict-equalESLint rule.User-visible changes
None. Tests only.
Testing
npm run formatnpm run test