Repository navigation
refactor: list optional properties last in inline object types - #3302
Open
Lightning00Blade wants to merge 1 commit into
Open
Lightning00Blade wants to merge 1 commit into
Lightning00Blade wants to merge 1 commit into
Conversation
Reorder 15 inline object types in 7 source files so that optional properties come after required ones. The change only affects types. This matches the DevTools `enforce-optional-properties-last` ESLint rule. Its autofix is not used because it moves properties without their JSDoc comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3301.
Reorders 15 inline object types in 7 source files so that optional properties come after required ones. The change only affects types.
This matches the DevTools
enforce-optional-properties-lastESLint rule. Its autofix is not used because it moves properties without their JSDoc comments (for example, thereadOnlyHintcomment inToolDefinition.tswould end up ontitle).User-visible changes
None.
Testing
npm run formatnpm run test