fix(s3): make AWS credentials optional so EKS pods can auth via IRSA#11
Merged
Conversation
The S3 and Secrets Manager clients always passed `credentials` explicitly and threw when static keys were absent. Passing `credentials` disables the AWS SDK default provider chain, so a pod holding an IRSA / Pod Identity role could never authenticate without static keys. Omit `credentials` when the keys are blank, letting the SDK resolve the pod role; keep passing them when both are present (static keys / local MinIO). Also fix the Rancher onboarding check, which required bucket + both keys and so never marked S3 configured on a keyless IRSA setup. It now needs only s3_bucket, treating a half-filled key pair as unconfigured. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S3 and Secrets Manager clients always passed
credentialsexplicitly and threw when static keys were absent. Passingcredentialsdisables the AWS SDK default provider chain, so a pod holding an IRSA / Pod Identity role could never authenticate without static keys.Omit
credentialswhen the keys are blank, letting the SDK resolve the pod role; keep passing them when both are present (static keys / local MinIO).Also fix the Rancher onboarding check, which required bucket + both keys and so never marked S3 configured on a keyless IRSA setup. It now needs only s3_bucket, treating a half-filled key pair as unconfigured.