Repository navigation
[repo] Cluster Tests - #3187
Open
chernser wants to merge 7 commits into
Open
[repo] Cluster Tests#3187chernser wants to merge 7 commits into
chernser wants to merge 7 commits into
Conversation
…rget server information
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 96eb6b4. Configure here.
| commandSettings.serverSetting("allow_experimental_json_type", "1"); | ||
| client.execute("DROP TABLE IF EXISTS test_json_values", commandSettings).get(1, TimeUnit.SECONDS); | ||
| client.execute("CREATE TABLE test_json_values (json JSON) ENGINE = MergeTree ORDER BY ()", commandSettings).get(1, TimeUnit.SECONDS); | ||
| client.execute("CREATE TABLE test_json_values (json JSON)", commandSettings).get(1, TimeUnit.SECONDS); |
There was a problem hiding this comment.
JSON table create omits ORDER BY
Medium Severity
testReadingJSONValues now creates test_json_values with neither an engine nor ORDER BY. Other tests in this change kept ORDER BY after dropping ENGINE = MergeTree. MergeTree and ReplicatedMergeTree (the cluster default_table_engine) require a sorting key unless create_table_empty_primary_key_by_default is on, so this create fails in both single and cluster container modes.
Reviewed by Cursor Bugbot for commit 96eb6b4. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerForTeststo have container starter separately from general API to get information about target systemCloses #2680
Closes #3186
Checklist
Delete items not relevant to your PR: