Report service start and stop acknowledgments accurately - #951
Merged
Merged
Conversation
sdairs
added this pull request to stack #876
September 15, 2026 15:31
sdairs
force-pushed
the
codex/focused-917
branch
from
September 15, 2026 15:49
832f724 to
168dabc
Compare
sdairs
marked this pull request as ready for review
September 16, 2026 13:14
Carry existing lower-stack README corrections and ancestry forward. The merged tree matches the independently verified cumulative stack result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Service start and stop confirmations now report request acceptance and the state returned by the API. They no longer claim a transition is underway when the immediate response says
runningorstopped, and do not infer a no-op or completed transition from that response.JSON and request behavior are unchanged; missing states remain visible as
-.Fixes #917.
Validation
Focused mock tests cover target-looking, in-progress and missing states, exact request bodies, and unchanged JSON for both commands. Formatting and diff checks passed; complete combined validation is recorded below.
Stack
Appended to native stack 876 after #950.
Combined local validation
Combined stack head
e20d63b3af4c8541a6f597d9494b530f2c56b666passed all required local checks: formatting, CLI clippy/tests, telemetry-disabled check and all-target clippy, API/analyzer all-target clippy/tests, all-feature workspace build, Python classifier/drift tests, and diff checks.Test totals: 1991 CLI, 672 API/analyzer, and 93 Python tests (2756 total). Ignored/live tests are excluded from these totals.
Snapshot API access was revalidated successfully on the exact heads of PRs #940 and #944 after the environment feature flag was enabled. Run links and coverage details are recorded in tracker #939.
Stack order, exact heads and explicit issue Development relationships were verified in the implementation tracker.