252 extract duplicated inline types - #288
Merged
Merged
Conversation
…n types & created index.ts file so it can be uploaded from @/types
nourshoreibah
approved these changes
Jul 27, 2026
nourshoreibah
left a comment
nourshoreibah
left a comment
Collaborator
There was a problem hiding this comment.
look great, thank you
shreeyaadhikari
approved these changes
Jul 29, 2026
shreeyaadhikari
left a comment
shreeyaadhikari
left a comment
Contributor
There was a problem hiding this comment.
looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #252
📝 Description
Extracted the Project, User, and Expenditure types into their own files in the types directory so they can be shared across all frontend files
Briefly list the changes made to the code:
✔️ Verification
No new tests written; just reran the existing frontend Jest tests to make sure everything still worked
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!