Admin Bugbash Fixes - #206
Open
jiang-h-y wants to merge 3 commits into
Open
Conversation
dburkhart07
approved these changes
Jul 27, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
just one small comment.
while we are at it, for adding a new user, can you also change "Please fill in all fields. " to not have the "" anymore?
| import { useAlert } from '../hooks/alert'; | ||
| import { getInitials, USER_ICON_COLORS } from '@utils/utils'; | ||
|
|
||
| const VolunteerManagement: React.FC = () => { |
There was a problem hiding this comment.
Can we just change this to UserManagement everywhere? Since its admin and volunteers, its kinda confusing like this.
Yurika-Kan
self-requested a review
July 30, 2026 08:01
Yurika-Kan
approved these changes
Jul 30, 2026
Yurika-Kan
left a comment
Yurika-Kan
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, one nit to address but then all good. thanks for fixing these, esp on adding the user feature :))
| const [isEditing, setIsEditing] = useState(false); | ||
|
|
||
| const donationId = donation.donationId; | ||
| const donationId = donation?.donationId; |
Collaborator
There was a problem hiding this comment.
nit: when we do optional chaining, it results in Donation | undefined, which becomes inconsistent with donation's form (Donation | null). can we clean it to
const donationId = donation ? donation.donationId : null;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
N/A
📝 Description
Note: the focus trap errors were intermittent, but I haven't been able to reproduce them since adding these fixes.
✔️ Verification
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!
Note: At one point, I found a bug where the "Manufacturer Management" page disappeared in the navbar. I tried for a while to reproduce this bug, but I wasn't able to, so I didn't implement a fix. Not sure if it's a recurring bug or if something strange just happened that time.